fix: add missing Export-Package to mcp-json-jackson2 and mcp-json-jackson3#911
Merged
Kehrlann merged 1 commit intoMay 28, 2026
Conversation
joaodinissf
changed the title
Contributor
Author
|
@Kehrlann Would you (or someone in the team) have some time to review this? Thanks a lot in advance. |
Contributor
Author
|
Just noticed this seems to address the same concern as #951 (closing #948). The differences: this PR enumerates the packages each module actually publishes — so no future internal subpackage gets auto-exported — and keeps Happy to defer to maintainers on which shape to land. |
Contributor
Author
|
@chemicL apologies for persisting — could you (or another maintainer) take a look at this? Happy to address any questions/concerns. |
Kehrlann
added
bug
Use explicit package names instead of a wildcard glob to avoid embedding mcp-core classes into the jackson module JARs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kehrlann
force-pushed
the
fix/osgi-export-jackson-modules
branch
from
421f4e7 to
5ed8bcc
Compare
Kehrlann
approved these changes
May 28, 2026
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit
Export-Packagedirectives to the jackson modules so OSGi consumers can access classes directly.Motivation and Context
PR #779 added bnd configuration to the jackson modules but omitted
Export-Package(whichmcp-corehas). Without it, all packages are bundle-private, which prevents direct instantiation ofJacksonMcpJsonMapperSupplierorDefaultJsonSchemaValidatorfrom other bundles — the recommended workaround per #562 sinceServiceLoader.load()does not work across OSGi bundle boundaries.This particularly affects Eclipse PDE and Tycho-based projects, which get compile-time "Access restriction" errors and runtime
ClassNotFoundExceptionwhen referencing classes from these modules.How Has This Been Tested?
Verified the generated
META-INF/MANIFEST.MFaftermvn process-classescontains the correctExport-Packageheader with only the module's own packages. Also tested in an Eclipse PDE project — the patched modules compile and resolve without issues.Breaking Changes
No.
Types of changes
Checklist
🤖 Generated with Claude Code